Fix `rust` / `generate artifacts` / `python` workflows [OI-3062] #1485

armallen · 2025-07-09T15:44:04Z

Description

Rust build failed because of two things:

clippy reported hundreds of error: variables can be used directly in the format! string lint errors
Once the lint fixed, macos build failed because it reliew on brew install cmake, which installed cmake>=4.0, which is not compatible with the codebase ( CMake Error at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake.)

Then other workflows failed because deprecated ubuntu 20.04 was used in two places, but is not available anymore since 2025-04-15.

Lints are fixed, cmake version is pinned and installed with dedicated github action.
Ubuntu 20.04 runners are updated to use 24.04. If ubuntu 20.04 really needs to be used, then we'll need to use a docker image.

⚠️ WARNING
Benchmark workflow had not been running for a few month (since `xlarge` runner was removed). We now have an `xlarge-24.04` runner that could run this workflow, but the build process is not compatible with `ubuntu 24.04` I updated the runner to `ubuntu-22.04` so that the benchmark step runs, but the runner itself is not "fast enough". I don't wish to spend more time fixing that right now.

API compatibility

No API change

API compatibility plan

No API change

JIRA Reference

https://swift-nav.atlassian.net/browse/OI-3062

armallen · 2025-07-09T16:54:46Z

.github/workflows/generator.yaml

@@ -18,8 +18,8 @@ on:
 jobs:
  generation:
    name: Generated artifacts
-    runs-on: ubuntu-20.04
-    container: 
+    runs-on: ubuntu-24.04


I believe this workflow can run on anything since it's using a container below

armallen · 2025-07-09T16:55:23Z

.github/workflows/rust.yaml

+      - name: Setup cmake
+        uses: jwlawson/actions-setup-cmake@v2
+        with:
+          cmake-version: "3.31.2"
+


Pinned to this version because why not?

I think the minimum CMake version used anywhere right now should be 3.13. So maybe the solution is rather to update this repo's demands?

The issue occurs here
which is in the rust build of swiftnav-rs, which seems to be pulling/building libswiftnav using a generated cmake file

I don't have enough motivation to investigate/fix that today 😆

Going to merge this PR as it is, I created this ticket to fix the public libswiftnav repo and swiftnav-rs separately https://swift-nav.atlassian.net/browse/OI-3100

armallen · 2025-07-09T16:56:07Z

generator/sbpg/targets/resources/rust/test/sbp_tests_template.rs

@@ -51,7 +51,7 @@ fn test_(((s.suite_name|snake_case)))()
        match &sbp_msg {
            sbp::messages::Sbp::(((t.msg.name|lower_acronyms)))(msg) => {
                let msg_type = msg.message_type().unwrap();
-                assert_eq!( msg_type, (((t.msg_type))), "Incorrect message type, expected (((t.msg_type))), is {}", msg_type);
+                assert_eq!( msg_type, (((t.msg_type))), "Incorrect message type, expected (((t.msg_type))), is {msg_type}");


msg_type moved in between the curly braces to fix all lints in automatically generated tests

armallen · 2025-07-09T16:56:34Z

scripts/ci_prepare_rust.bash

@@ -7,7 +7,7 @@ if [ "$RUNNER_OS" == "Linux" ]; then
    sudo apt-get -qq install -y pkg-config build-essential libudev-dev musl-tools
    rustup target add x86_64-unknown-linux-musl
 elif [ "$RUNNER_OS" == "macOS" ]; then
-    brew install cmake
+    echo "Nothing to do for macOS"


cmake is installed with github action now

armallen · 2025-07-09T17:30:41Z

Just noticed benchmarks were running on an old xlarge runner, trying it with xlarge-24.04?

Madhunika-atmakuri

Do we know why it skipped the Rust check?

armallen · 2025-07-10T07:27:52Z

Do we know why it skipped the Rust check?

Yes the publish step only runs for releases:

libsbp/.github/workflows/rust.yaml

Line 111 in c2c7cd1

if: startsWith(github.ref, 'refs/tags/v')

sonarqubecloud · 2025-07-10T08:01:50Z

Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

armallen · 2025-07-10T08:18:05Z

.github/workflows/python.yaml

@@ -18,7 +18,7 @@ on:
 jobs:
  coverage:
    name: Test
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04


Updated to ubuntu-22.04 because the python dependencies build procedures are not portable and no wheels are available for newer OS versions (pip install fails on ubuntu-24.04 with default python version).

Wheels are available for ubuntu-22.04.

armallen added 8 commits July 9, 2025 17:42

Rust lint

a6af6e5

Update template

e17e97e

Fix rust?

fa2abfd

Fix again

bbaae69

Don't install CMake manually

5bfc6a6

Add something for macos

aac3df7

Use ubuntu 24?

77ddac1

Generate on more recent ubuntu

7163a22

armallen changed the title ~~Fix rust build~~ Fix all github workflows Jul 9, 2025

armallen commented Jul 9, 2025

View reviewed changes

armallen changed the title ~~Fix all github workflows~~ Fix workflows [OI-3062] Jul 9, 2025

armallen changed the title ~~Fix workflows [OI-3062]~~ Fix rust / generate artifacts workflows [OI-3062] Jul 9, 2025

armallen marked this pull request as ready for review July 9, 2025 17:28

armallen requested review from notoriaga, pcrumley and a team as code owners July 9, 2025 17:28

Try benchmarks on 24.04?

c2c7cd1

notoriaga approved these changes Jul 9, 2025

View reviewed changes

pcrumley approved these changes Jul 9, 2025

View reviewed changes

Madhunika-atmakuri reviewed Jul 9, 2025

View reviewed changes

armallen added 5 commits July 10, 2025 09:36

Test with updated prepare script

f73ed78

Try python step too

604b832

Test on 22.0.4

aaee868

Standard ubuntu

140417a

update

e71563f

armallen changed the title ~~Fix rust / generate artifacts workflows [OI-3062]~~ Fix rust / generate artifacts / python workflows [OI-3062] Jul 10, 2025

armallen commented Jul 10, 2025

View reviewed changes

Madhunika-atmakuri approved these changes Jul 10, 2025

View reviewed changes

armallen merged commit 635fc94 into master Jul 17, 2025
14 of 15 checks passed

armallen deleted the armallen/fix-rust branch July 17, 2025 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `rust` / `generate artifacts` / `python` workflows [OI-3062] #1485

Fix `rust` / `generate artifacts` / `python` workflows [OI-3062] #1485

Uh oh!

armallen commented Jul 9, 2025 •

edited

Loading

Uh oh!

armallen Jul 9, 2025

Uh oh!

armallen Jul 9, 2025

Uh oh!

sbmueller Jul 10, 2025

Uh oh!

armallen Jul 10, 2025

Uh oh!

armallen Jul 17, 2025

Uh oh!

armallen Jul 9, 2025

Uh oh!

armallen Jul 9, 2025

Uh oh!

armallen commented Jul 9, 2025

Uh oh!

Madhunika-atmakuri left a comment

Uh oh!

armallen commented Jul 10, 2025

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Uh oh!

armallen Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

Fix rust / generate artifacts / python workflows [OI-3062] #1485

Fix rust / generate artifacts / python workflows [OI-3062] #1485

Uh oh!

Conversation

armallen commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

API compatibility

API compatibility plan

JIRA Reference

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armallen commented Jul 9, 2025

Uh oh!

Madhunika-atmakuri left a comment

Choose a reason for hiding this comment

Uh oh!

armallen commented Jul 10, 2025

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Quality Gate passed for 'libsbp-c'

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fix `rust` / `generate artifacts` / `python` workflows [OI-3062] #1485

Fix `rust` / `generate artifacts` / `python` workflows [OI-3062] #1485

armallen commented Jul 9, 2025 •

edited

Loading